src: zero-initialize cap_data in node_credentials.cc#64347
Merged
Conversation
nodejs-github-bot
added
c++
spkapust
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64347 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 741 741
Lines 240979 241166 +187
Branches 45401 45424 +23
==========================================
+ Hits 217449 217617 +168
- Misses 15112 15122 +10
- Partials 8418 8427 +9
🚀 New features to boost your workflow:
|
Contributor
|
Can you amend the commit with the fixed message? Unfortunately changing the PR title isn't sufficient to pass the check. |
zero-initialize the cap_data array to prevent MSan warnings about using uninitialized memory Signed-off-by: Sam Kapust <samkapust@google.com>
hybrist
approved these changes
Jul 8, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
hybrist
added
the
author ready
lpinca
approved these changes
Jul 8, 2026
Collaborator
Collaborator
Contributor
|
@spkapust Can you try rebasing on latest main? Not sure why the windows CI isn't passing for this change. |
Collaborator
Collaborator
hybrist
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e7864e6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero-initialize the cap_data array to prevent MSan warnings
about using uninitialized memory.
Signed-off-by: Sam Kapust samkapust@google.com